Fix backup authentication method variable resolution #381
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kasparsd
commented
Aug 26, 2020
| @@ -71,7 +71,7 @@ public static function get_instance() { | |||
| * Returns the name of the provider. | |||
| */ | |||
| public function get_label() { | |||
| return _x( 'Time Based One-Time Password (Google Authenticator)', 'Provider Label', 'two-factor' ); | |||
| return _x( 'Time Based One-Time Password (TOTP)', 'Provider Label', 'two-factor' ); | |||
There was a problem hiding this comment.
There are more ways to do TOTP these days so make it generic.
| @@ -142,7 +142,7 @@ public function user_two_factor_options( $user ) { | |||
| </p> | |||
| <?php else : ?> | |||
| <p class="success"> | |||
| <?php esc_html_e( 'Secret key configured and registered.', 'two-factor' ); ?> | |||
| <?php esc_html_e( 'Secret key is configured and registered. It is not possible to view it again for security reasons.', 'two-factor' ); ?> | |||
There was a problem hiding this comment.
This has been a frequent question in the support forums so we explain why the secret key is not shown again.
| @@ -454,6 +454,9 @@ public function is_available_for_user( $user ) { | |||
| public function authentication_page( $user ) { | |||
| require_once ABSPATH . '/wp-admin/includes/template.php'; | |||
| ?> | |||
| <p> | |||
| <?php esc_html_e( 'Please enter the code generated by your authenticator app.', 'two-factor' ); ?> | |||
There was a problem hiding this comment.
Explain where to get the code from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #340.
Props @joshbetz!